neglect try_run() in sqlite and always build release and shared libray#55
Open
cia1099 wants to merge 2 commits intosjinks:masterfrom
Open
neglect try_run() in sqlite and always build release and shared libray#55cia1099 wants to merge 2 commits intosjinks:masterfrom
cia1099 wants to merge 2 commits intosjinks:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR works around cross-compiling detection errors and standardizes the build output.
- Defines
HAVE_GNU_STRERROR_R_EXITCODEandHAVE_GNU_STRERROR_R_COMPILEDto bypasstry_run()in cross-compiling mode - Forces
CMAKE_BUILD_TYPEtoRelease - Enables
BUILD_SHARED_LIBSby default
Comments suppressed due to low confidence (2)
CMakeLists.txt:11
- [nitpick] Unconditionally setting CMAKE_BUILD_TYPE forces a Release build and prevents users from selecting other build types; consider allowing overrides via a cached option or command-line flag.
set(CMAKE_BUILD_TYPE Release)
CMakeLists.txt:12
- [nitpick] Forcing BUILD_SHARED_LIBS reduces flexibility for consumers who may need a static library; consider making this an option or honoring user-specified values.
set(BUILD_SHARED_LIBS ON)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
I am highly recommend to set build release mode and shared library as default, because user never care this third party library executable debug for break point and any log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is Error occur when build with NDK:
CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
HAVE_GNU_STRERROR_R_EXITCODE (advanced)